Skip to content

no-jira: Vendor kuberay python client#930

Merged
openshift-merge-bot[bot] merged 1 commit into
project-codeflare:mainfrom
kryanbeane:vendor-python-client
Oct 16, 2025
Merged

no-jira: Vendor kuberay python client#930
openshift-merge-bot[bot] merged 1 commit into
project-codeflare:mainfrom
kryanbeane:vendor-python-client

Conversation

@kryanbeane

@kryanbeane kryanbeane commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

Issue link

No Jira

What changes have been made

Vendored the Kuberay Python client as PyPi doesn't allow direct git installs of packages, and the client hasn't been published to PyPi yet. Once it has been, we can remove this

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci-robot

openshift-ci-robot commented Oct 16, 2025

Copy link
Copy Markdown
Collaborator

@kryanbeane: This pull request explicitly references no jira issue.

Details

In response to this:

Issue link

No Jira

What changes have been made

Vendored the Kuberay Python client as PyPi doesn't allow direct git installs of packages, and the client hasn't been published to PyPi yet. Once it has been, we can remove this

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kryanbeane kryanbeane force-pushed the vendor-python-client branch 3 times, most recently from 5b78444 to 9b29ded Compare October 16, 2025 11:19
@kryanbeane kryanbeane force-pushed the vendor-python-client branch from 9b29ded to d009a49 Compare October 16, 2025 11:23
@codecov

codecov Bot commented Oct 16, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.34%. Comparing base (afe21b3) to head (d009a49).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #930      +/-   ##
==========================================
+ Coverage   94.24%   94.34%   +0.09%     
==========================================
  Files          24       24              
  Lines        2033     2068      +35     
==========================================
+ Hits         1916     1951      +35     
  Misses        117      117

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chipspeak chipspeak self-requested a review October 16, 2025 11:26
@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 16, 2025
@openshift-ci

openshift-ci Bot commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chipspeak, pawelpaszki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [chipspeak,pawelpaszki]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 67df4f5 into project-codeflare:main Oct 16, 2025
20 checks passed
@kryanbeane kryanbeane deleted the vendor-python-client branch October 16, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pawelpaszki pawelpaszki pawelpaszki approved these changes

@chipspeak chipspeak chipspeak approved these changes

@laurafitzgerald laurafitzgerald Awaiting requested review from laurafitzgerald

Assignees

@pawelpaszki pawelpaszki

@chipspeak chipspeak

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kryanbeane @openshift-ci-robot @pawelpaszki @chipspeak